Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do with /system/indy-sdk-tests tests #150

Open
WadeBarnes opened this issue May 16, 2024 · 2 comments
Open

Decide what to do with /system/indy-sdk-tests tests #150

WadeBarnes opened this issue May 16, 2024 · 2 comments

Comments

@WadeBarnes
Copy link
Member

WadeBarnes commented May 16, 2024

system/indy-sdk-tests rely on the deprecated indy-sdk, these tests should be migrated to use indy-vdr, or deprecated and removed.

@swcurran
Copy link
Member

Do you have an opinion @WadeBarnes ? Presumably there is an example of how to change tests from one to the other. Do you know of any example? I did see in the payments tests removal PR that some of those were using indy VDR.

@WadeBarnes
Copy link
Member Author

My opinion is the we should keep and migrate tests that appear to have value. Which those are, I don't know, because I haven't looked that deeply into it.

May of the tests were migrated from using the indy-sdk to indy-vdr already, that history can be used as the reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants