Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting blank windows by using rounding #8969

Closed
6 tasks done
SomeEmptyBox opened this issue Jan 6, 2025 · 23 comments · Fixed by #8971
Closed
6 tasks done

getting blank windows by using rounding #8969

SomeEmptyBox opened this issue Jan 6, 2025 · 23 comments · Fixed by #8971
Labels
bug Something isn't working

Comments

@SomeEmptyBox
Copy link

SomeEmptyBox commented Jan 6, 2025

Already reported ? *

  • I have searched the existing open and closed issues.

Regression?

Not a regression - it's bug regarding new feature

System Info and Hyprland Version

System/Version info
Hyprland 0.46.0 built from branch  at commit f390f48a07d117e24acec59dcf6791bcb3a81110  ().
Date: 2025-01-05
Tag: v0.46.0, commits: 
built against:
 aquamarine 0.5.1
 hyprlang 0.6.0
 hyprutils 0.3.0
 hyprcursor 0.1.11
 hyprgraphics 0.1.1


no flags were set


System Information:
System name: Linux
Node name: nixos
Release: 6.12.8
Version: #1-NixOS SMP PREEMPT_DYNAMIC Thu Jan  2 09:34:26 UTC 2025


GPU information: 
00:02.0 VGA compatible controller [0300]: Intel Corporation CometLake-U GT2 [UHD Graphics] [8086:9b41] (rev 02) (prog-if 00 [VGA controller])


os-release: ANSI_COLOR="0;38;2;126;186;228"
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="25.05.20250104.8f3e1f8"
CPE_NAME="cpe:/o:nixos:nixos:25.05"
DEFAULT_HOSTNAME=nixos
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
ID_LIKE=""
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 25.05 (Warbler)"
SUPPORT_URL="https://nixos.org/community.html"
VARIANT=""
VARIANT_ID=""
VENDOR_NAME=NixOS
VENDOR_URL="https://nixos.org/"
VERSION="25.05 (Warbler)"
VERSION_CODENAME=warbler
VERSION_ID="25.05"


plugins:

Description

after completing the update and reboot of my nixos system, any window i open are blank and i see some wierd circles at corners
2025-01-06-130344_hyprshot
i get this if the value of rounding is anything more than 0.

How to reproduce

  1. set rounding value to more than 0

Attach not paste

  • I understand that all text files must be attached, and not pasted directly. If not respected, this issue will likely get closed as spam

Checklist of files to include below

  • Hyprland config - hyprctl systeminfo -c (always include)
  • Crash report (always include in case of crash)
  • Video (always include in case of a visual bug)
  • Logs (might contain useful info such as errors)

Additional info & File uploads

i'm not about to record and i only have access to this pc for now and the windows are blank so can't navigate.

hyprland-cache-logs.txt
hyprland_config_dump.txt
hyprland-XDG_RUNTIME_DIR.log

@SomeEmptyBox SomeEmptyBox added the bug Something isn't working label Jan 6, 2025
@ikkihou
Copy link

ikkihou commented Jan 6, 2025

2025-01-06.17-32-50.mp4

i have the same problem

@cpiber
Copy link

cpiber commented Jan 6, 2025

I face the same problem. For me native wayland applications let the background show through, and xwayland (or Electron?) seem to not render properly, where the window is white and the mouse cursor "drags" through.

@vaxerski
Copy link
Member

vaxerski commented Jan 6, 2025

uh huh intel doesn't like something about the new shaders I am guessing #8943 @polluxcodes

@polluxcodes
Copy link
Contributor

I'll take a look.

@polluxcodes
Copy link
Contributor

polluxcodes commented Jan 6, 2025

Looking at the screenshot, it seems the issue is probably in the Textures.hpp file, since the borders look ok. Can anyone check if the shadows work?

@cpiber
Copy link

cpiber commented Jan 6, 2025

Looking at the screenshot, it seems the issue is probably in the Textures.hpp file, since the borders look ok. Can anyone check if the shadows work?

I have shadows enabled like in the default config, anything I should see? I honestly can't see a difference, so maybe no

@polluxcodes
Copy link
Contributor

@cpiber If they are working, you should be able to see them around the borders, but not within them.

@cpiber
Copy link

cpiber commented Jan 6, 2025

Had to change the color and bump up the range, yes, they're working

20250106_17h47m23s_grim

@polluxcodes
Copy link
Contributor

@cpiber Do they still work with rounding>0?

@cpiber
Copy link

cpiber commented Jan 6, 2025

No, setting rounding to a positive number like in the default config creates the above situation. I had shadows enabled like in the default config and encountered that. Tested again to be certain, it happens with and without shadows.

@polluxcodes
Copy link
Contributor

@cpiber Sorry, I meant do the shadows specifically work as I described earlier. I'm trying to see which of the three shaders that I modified are broken.

@cpiber
Copy link

cpiber commented Jan 6, 2025

My bad, misunderstood. Here is a screenshot of the new shadow. Definitely seems larger than before, and seems to reach into the window.

20250106_17h57m46s_grim

@polluxcodes
Copy link
Contributor

polluxcodes commented Jan 6, 2025

Actually, the way shadows are rendered, the shadow's shader is probably fine, since it uses the textures shader to create the mask to remove the part inside the window. I'm going to make a PR to revert most of the alterations to the textures shader.

@SomeEmptyBox
Copy link
Author

i was on this commit when everything was working as expected b0bae15 if that helps

@polluxcodes
Copy link
Contributor

I'm 99.9% sure it is commit a5c1437 that broke it, so that lines up.

@polluxcodes
Copy link
Contributor

polluxcodes commented Jan 6, 2025

Can someone having issues try PR #8971? It reverts most of the changes I made in the Textures.hpp file. If that works, it should be ready to merge.

I verified it works on AMD still, but don't own an Intel card to test on that.

@SomeEmptyBox
Copy link
Author

i'm new to these thing, how can i check ? i have intel cpu with igpu

@cpiber
Copy link

cpiber commented Jan 6, 2025

@SomeEmptyBox How did you install Hyprland? You would need to check out that branch and compile from there. But I already did and it seems to be fixed

@SomeEmptyBox
Copy link
Author

@cpiber did you check on intel ? then it should be fine, i use nixos and flake to install directly from latest git commit

@cpiber
Copy link

cpiber commented Jan 6, 2025

Yes, I'm on Intel, and I had the same bug on main @SomeEmptyBox

polluxcodes added a commit to polluxcodes/Hyprland that referenced this issue Jan 6, 2025
polluxcodes added a commit to polluxcodes/Hyprland that referenced this issue Jan 6, 2025
@polluxcodes
Copy link
Contributor

@SomeEmptyBox @cpiber I think I know why this wasn't caught on my end. Can one of you try enabling blur when using the broken commit?

@cpiber
Copy link

cpiber commented Jan 6, 2025

I had the same suspicion, already tested with and without, no difference for me

@polluxcodes
Copy link
Contributor

@vaxerski The fix is ready in PR #8971.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants