Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 19 #78

Open
acelaya opened this issue Jan 2, 2025 · 5 comments · May be fixed by #79
Open

Support React 19 #78

acelaya opened this issue Jan 2, 2025 · 5 comments · May be fixed by #79
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@acelaya
Copy link

acelaya commented Jan 2, 2025

Describe the solution you'd like

It would be great to allow installing this library with React 19, which is currently not that straightforward due to the peer dependency on react ^18.0.0.

Describe alternatives you've considered

Depending on the package manager you use, it's possible to bypass conflicting peer dependencies, but that can be problematic as it could cause the accidental installation of a dependency that doesn't actually work.

Additional context

N/A

@i-like-robots
Copy link
Owner

Thanks @acelaya for raising this. Whilst it's easy to amend the peer dependency range the component does need testing against React 19 and that will require some re-jigging to enable this to be automated.

@acelaya
Copy link
Author

acelaya commented Jan 3, 2025

I think it should be possible to automate it via workflow matrix. I can take a look if you want.

@i-like-robots
Copy link
Owner

I'd really appreciate any contributions 🙏

@acelaya acelaya linked a pull request Jan 4, 2025 that will close this issue
@acelaya
Copy link
Author

acelaya commented Jan 4, 2025

I have just given it a try at #79. Let me know what you think.

@acelaya
Copy link
Author

acelaya commented Jan 9, 2025

@i-like-robots let me know what you think about #79. If that's not what you had in mind, I'm happy to take a different path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants