Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/module.js references place.html which does not exist #440

Closed
cjolif opened this issue Jan 2, 2015 · 2 comments
Closed

tests/module.js references place.html which does not exist #440

cjolif opened this issue Jan 2, 2015 · 2 comments
Assignees
@wkeese

Comments

@cjolif
Copy link
Contributor

cjolif commented Jan 2, 2015

Also I see delite/place is already tested in tests/unit, so does it make sense to keep tests/place-clip.html & tests/place-margin.html?
@wkeese
Copy link
Member

wkeese commented Jan 3, 2015

ibm-js/delite@732653a converted the old place.html test to Intern but not the other files. I guess I should convert the other tests too.

@wkeese wkeese self-assigned this Jan 3, 2015
@wkeese
Copy link
Member

wkeese commented Jan 3, 2015

I removed the lline from module.js in ibm-js/delite@57951d2, and filed ibm-js/delite#357 about converting the remaining tests.

Note that this is a delite issue, not deliteful, so the original ticket should have been against delite.

@wkeese wkeese closed this as completed Jan 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkeese wkeese

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wkeese @cjolif