Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner doesn't working fine when calling "show" method next time #96

Open
ghost opened this issue Jan 16, 2017 · 7 comments
Open

Spinner doesn't working fine when calling "show" method next time #96

ghost opened this issue Jan 16, 2017 · 7 comments

Comments

@ghost
Copy link

ghost commented Jan 16, 2017

Spinner doesn't working fine when I want to show it next time..
Can someone helping me please?

@jessiemblack
Copy link

You should be more specific in your answer. Your problem is unclear.

@robcecil
Copy link

robcecil commented Nov 7, 2017

I have seen this problem too @jessalbarian

I use SwiftSpinner with RxSwift (through a code pattern called ActivityIndicator), and out side of it, and when I do:

SwiftSpinner.show(<text 1>, animate: true)
then
SwiftSpinner.hide()
then immediately
SwiftSpinner.show(<text 2>, animate: true)

The second spinner will not appear.

@DavidLari
Copy link
Contributor

Have you tried it without the hide?

@robcecil
Copy link

robcecil commented Nov 7, 2017

Yes. It works properly without a hide() called between the two show() method calls.

That is not a good solution for me however. If I have two separate network calls, independent of each other, and non-deterministically sequenced, I need to sandwich each call with a pair of show/hide somehow.

@icanzilb
Copy link
Owner

icanzilb commented Nov 7, 2017

You could try showing/hiding SwiftSpinner.sharedInstancedirectly, but I haven't tried that before not sure if it's a brilliant idea ... though, if it works in your case - why not :)

@sam199488
Copy link

I'm facing the same issue (hide between two show, the last show doesn't work)
@icanzilb what do you mean by "showing/hiding SwiftSpinner.sharedInstance directly" ?

@andreamazz
Copy link
Collaborator

Hey @sam199488
I reckon this issue should be fixed by one of the latest PR (#122).
Can you test against the master version of the lib?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants