Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages when invalid requested_core_field exception submitted. #982

Open
edsu7 opened this issue May 17, 2023 · 0 comments
Open
Assignees
Labels
clinical exceptions new-feature Request is a new feature

Comments

@edsu7
Copy link

edsu7 commented May 17, 2023

The error message provided for a non-existent requested_core_field is the same as an invalid/non-eligible requested_core_field (e.g. ID) field in the https://clinical.qa.argo.cancercollaboratory.org/exception/TEST-GR/entity API.

Detailed Description

Non-existent field TSV:

program_name	submitter_donor_id	submitter_specimen_id	schema	requested_core_field	requested_exception_value
TEST-GR	TEST-DONOR_1	TEST-SPECIMEN_1	specimen	relapse_type	Unknown

API response:

"The requested_core_field 'relapse_type' does not match schema 'specimen'. Please update your exception request form."

ID field

program_name	submitter_donor_id	submitter_specimen_id	schema	requested_core_field	requested_exception_value
TEST-GR	TEST-DONOR_1	TEST-SPECIMEN_1	specimen	submitter_primary_diagnosis_id	Unknown

API response

"The requested_core_field 'submitter_primary_diagnosis_id' does not match schema 'specimen'. Please update your exception request form."

Possible Implementation

For the later, the API response could be:

"The requested_core_field 'submitter_primary_diagnosis_id' in schema 'specimen' is not eligible for exception. Please update your exception request form."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clinical exceptions new-feature Request is a new feature
Projects
None yet
Development

No branches or pull requests

4 participants