Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Application navigation from section to section #139

Open
2 tasks
kcullion opened this issue Jun 18, 2021 · 6 comments
Open
2 tasks

[UI] Application navigation from section to section #139

kcullion opened this issue Jun 18, 2021 · 6 comments
Labels
enhancement New feature or request low

Comments

@kcullion
Copy link

kcullion commented Jun 18, 2021

  • When the user clicks the previous/next buttons on the application, let's take them to the top of that new section. Currently it keeps them at the bottom of the page. Cannot reproduce this one, not doing.
  • When a new section loads, there's a bit of a flash - because there is no content for a second and you see the footer move up and down on the page. Can we implement the loader and a min-height for the application perhaps?
@kcullion kcullion added the enhancement New feature or request label Jun 18, 2021
@kcullion kcullion changed the title [UI] Previous/next button behaviour [UI] Application navigation from section to section Jun 18, 2021
@justincorrigible
Copy link
Member

justincorrigible commented Jun 21, 2021

Note for whenever we address this ticket:
The scrolling behaviour described here is not possible at the moment in our app, due to a bug in NextJS when using shallow navigation (i.e. when we update the URL without an unnecessary page refresh).

The default behaviour (see scroll at router.push) is for the page to scroll back up unless instructed not to by the developer, yet there seems to be a problem in their implementation that is being resolved here: vercel/next.js#24888 (review).
We just need to get their update in order to solve the issue.

@kcullion
Copy link
Author

@caravinci gotcha. Not a problem - this is more of a nice to have

@justincorrigible
Copy link
Member

Very nice to have, indeed! it irked me when I noticed that bug a couple weeks ago, and I've been keeping tabs on this.
Glad you made a ticket for it! 🙏

@rosibaj
Copy link
Contributor

rosibaj commented Jul 30, 2021

Removing from MVP epic for closing

@justincorrigible
Copy link
Member

justincorrigible commented Jul 30, 2021

As follow-up: The fix should be included in NextJS@11, as per the aforementioned PR in their repo.
We just need to update our version here, to benefit from the improvements and close this ticket.

@b-f-chan
Copy link

b-f-chan commented Apr 4, 2023

Icebox for refactor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low
Projects
None yet
Development

No branches or pull requests

4 participants