You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DCC can do sanity check here so make sure submitter IDs are consistent etc .
Future note: Need a validation between clinical and song to make sure IDs are consistent.
We need a function to enable data quality review before kicking off workflow automation.
The first step is just to give admins a chance to review the submitted data before it gets sent to automation, we don't want submitted data to start the automated pipeline immediately, but instead to have a step for human review and approval.
Detailed Description
Don’t want Model-T to be an officially supported tool that all RDPCs rely on… GoogleSheets should not be required data manager for our RDPCs.
Instead, we would add a new page to the Workflow UI that would let us view Submitted analyses and the workflows run on them. From this view, a data manager for the RDPC can approve each analysis to begin processing (button on the UI)
data manager will need to change the params sometimes. To support this, we could give access to the resume/restart api through this UI.
Need a list of analyses from submitted song, show wf that have been run on these(option 1: update analysis index to include wf data. Option 2: query wf for analysis ID ). If not any, need buttons to start the wf.
on each analysis, in order to start wf, need to change API to send msg to a new topic(msg has full analysis info), so ingest node will have same data as song_analysis topic.
Do we want to include info like analysis is validated? for a simple solution, as long as the msg is sent, we assume the analysis is validated.
Question:
what is being reviewed?
once users submit data -> pre-alignment QC -> alignment. We are skipping pre-align QC, because previous 25K has high quality data.
alignment to VC can be all automatic.
Pre-align QC what it is?
almost done, need to upgrade nextflow version, and test.
next step is to integrate pre-align QC into the pipeline.
once we have the pre-align QC, and data passes QC, will we need a manual step to kick off automation?
No.
what we need is if QC fails, need to let submitters know, and need:
until we have the QC, we need to disconnect the ingest node from song analysis topic.
step 1 : config change only, no code change.
rdpc-infra
step 2: ability to start wf pipeline after review
need a new API as part of the wf api, so that rdpc admin can request analysis id to be sent to the automation system.
the endpoint will get analysis info from song, and send it a kafka topic, and let ingest node listen to this topic. The switch is also a config change.
Why we need it?
DCC can do sanity check here so make sure submitter IDs are consistent etc .
Future note: Need a validation between clinical and song to make sure IDs are consistent.
We need a function to enable data quality review before kicking off workflow automation.
The first step is just to give admins a chance to review the submitted data before it gets sent to automation, we don't want submitted data to start the automated pipeline immediately, but instead to have a step for human review and approval.
Detailed Description
params
sometimes. To support this, we could give access to the resume/restart api through this UI.Question:
until we have the QC, we need to disconnect the ingest node from song analysis topic.
step 2: ability to start wf pipeline after review
step 3: ability to review submitted files, so we can pre-align check manually.
- start automation button(will replace model T)
What we know:
Future Step:
1.how to report QC failures?
Architecture: https://drive.google.com/file/d/1JI9dO-Hx098CvUFj-W4y6_46up2BRPF0/view?usp=sharing
The text was updated successfully, but these errors were encountered: