Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callable typing + type testing #91

Open
WyriHaximus opened this issue Dec 27, 2024 · 1 comment
Open

Add callable typing + type testing #91

WyriHaximus opened this issue Dec 27, 2024 · 1 comment
Milestone

Comments

@WyriHaximus
Copy link
Collaborator

To get this package fully type safe PHPStan supports type testing to ensure every type is working as intended. How to do this is described in https://blog.wyrihaximus.net/2024/06/updating-php-packages-to-reactphp-promise-v3--and-test-your-types-with-phpstan/ .

For more reference material I'm doing the same thing in reactphp-parallel/event-loop#51

@WyriHaximus WyriHaximus added this to the v4.0.0 milestone Dec 27, 2024
@ericsizemore
Copy link
Contributor

Hmm. I seem to recall running into some issues in trying to template the callables. I may have to take another look myself, since it's been several months. I haven't dove too deep into PHPStan 2 so I'm not sure what, if any, improvements they've made to typing Closures/callables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants