Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to work with latest version of code #28

Open
alexdewar opened this issue Sep 25, 2024 · 3 comments
Open

Update examples to work with latest version of code #28

alexdewar opened this issue Sep 25, 2024 · 3 comments
Assignees

Comments

@alexdewar
Copy link
Collaborator

The main problem seems to be that the static linear model definition has changed, but it looks like the EBHLM model definition may also change (imperialCHEPI/healthgps#531).

This doesn't need to be done until I've released the examples (#25). Are you happy to take this one at that point @jamesturner246? I'd be happy to have a go, but I'm not sure what realistic numbers for the new parameters would look like.

@jamesturner246
Copy link
Contributor

I'll put this on hold whilst the example stuff is ongoing.

@jamesturner246 jamesturner246 moved this from 🔖 Ready to 💁 Needs Info in Health-GPS Oct 4, 2024
@jamesturner246 jamesturner246 moved this from 💁 Needs Info to 🔖 Ready in Health-GPS Oct 7, 2024
@jamesturner246
Copy link
Contributor

@jzhu20, any chance I could get the latest version of Config.json, StaticLinear.json, KevinHall.json you are using when you get a moment? Just so I can copy the values into the examples repository. Cheers!

@jamesturner246
Copy link
Contributor

Some extra notes: mostly KevinHall etcetera schemas are updated, so old models shouldn't need much change if any, only newer.

Also CI needs updating to use the latest schemas available for each model config.

@jamesturner246 jamesturner246 moved this from 🔖 Ready to 🏗 In progress in Health-GPS Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants