Further extension to the analysis module #564
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/HealthGPS/analysis_module.cpp
Outdated
| } | ||
|
|
||
| // Calculate in-place standard deviation. | ||
| auto divide_by_count_sqrt = [&](const std::string &chan, core::Gender sex, int age, |
There was a problem hiding this comment.
warning: parameter 'age' is unused [misc-unused-parameters]
Suggested change
| auto divide_by_count_sqrt = [&](const std::string &chan, core::Gender sex, int age, | |
| auto divide_by_count_sqrt = [&](const std::string &chan, core::Gender sex, int /*age*/, |
src/HealthGPS/analysis_module.cpp
Outdated
| } | ||
|
|
||
| // Calculate in-place standard deviation. | ||
| auto divide_by_count_sqrt = [&](const std::string &chan, core::Gender sex, int age, |
There was a problem hiding this comment.
warning: parameter 'sex' is unused [misc-unused-parameters]
Suggested change
| auto divide_by_count_sqrt = [&](const std::string &chan, core::Gender sex, int age, | |
| auto divide_by_count_sqrt = [&](const std::string &chan, core::Gender /*sex*/, int age, |
src/HealthGPS/analysis_module.cpp
Outdated
| } | ||
|
|
||
| // Calculate in-place standard deviation. | ||
| auto divide_by_count_sqrt = [&](const std::string &chan, core::Gender sex, int age, |
There was a problem hiding this comment.
warning: unused parameter 'age' [clang-diagnostic-unused-parameter]
auto divide_by_count_sqrt = [&](const std::string &chan, core::Gender sex, int age,
^
src/HealthGPS/analysis_module.cpp
Outdated
| } | ||
|
|
||
| // Calculate in-place standard deviation. | ||
| auto divide_by_count_sqrt = [&](const std::string &chan, core::Gender sex, int age, |
There was a problem hiding this comment.
warning: unused parameter 'sex' [clang-diagnostic-unused-parameter]
auto divide_by_count_sqrt = [&](const std::string &chan, core::Gender sex, int age,
^
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## extend_analysis #564 +/- ##
===================================================
- Coverage 51.21% 50.87% -0.35%
===================================================
Files 165 165
Lines 8370 8427 +57
Branches 1070 1078 +8
===================================================
Hits 4287 4287
- Misses 4074 4131 +57
Partials 9 9 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the
AnalysisModuleclass in thesrc/HealthGPS/analysis_module.cppfile. The main changes include the addition of a new method to calculate standard deviations and a new overload for thecalculate_indexmethod to handle vector inputs.Added the
calculate_standard_deviationmethod to compute the standard deviation for various risk factors, based on the current population context. Uses the newcalculated_statsvector rather than theseriesobject.Introduced a new overload of the
calculate_indexmethod that accepts a vector of factor values and computes the corresponding index in thecalculated_stats_vector. This is useful for when you know the factor values without having to pass apersonobject.Closes #420
Closes #376