Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: How To Contribute the Infinity DataBase #1373

Closed
xiaoshengMr opened this issue Jun 21, 2024 · 5 comments
Closed

[Question]: How To Contribute the Infinity DataBase #1373

xiaoshengMr opened this issue Jun 21, 2024 · 5 comments
Labels
question Further information is requested

Comments

@xiaoshengMr
Copy link

xiaoshengMr commented Jun 21, 2024

Describe your problem

hello infinitycommiter , I would like to know how to contribute to this open source database including how to set up a local development environments in mac os and local testing and i can not find it in official website, Is there a contribute tutorial here

@xiaoshengMr xiaoshengMr added the question Further information is requested label Jun 21, 2024
@yingfeng
Copy link
Member

Hi, currently, Infinity could not be compiled under mac directly. You could try it within docker, and set up the compilation environment according to this guide.

@xiaoshengMr
Copy link
Author

xiaoshengMr commented Jun 22, 2024

LOG
cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_VERBOSE_MAKEFILE=ON ..
CMake Warning (dev) at CMakeLists.txt:29:
2024-06-22 18:20:53 Syntax Warning in cmake code at column 86
2024-06-22 18:20:53
2024-06-22 18:20:53 Argument not separated from preceding token by whitespace.
2024-06-22 18:20:53 This warning is for project developers. Use -Wno-dev to suppress it.
2024-06-22 18:20:53
2024-06-22 18:20:54 -- The C compiler identification is Clang 17.0.6
2024-06-22 18:20:55 -- The CXX compiler identification is Clang 17.0.6
2024-06-22 18:20:55 -- Detecting C compiler ABI info
2024-06-22 18:20:56 -- Detecting C compiler ABI info - done
2024-06-22 18:20:56 -- Check for working C compiler: /usr/bin/clang-17 - skipped
2024-06-22 18:20:56 -- Detecting C compile features
2024-06-22 18:20:56 -- Detecting C compile features - done
2024-06-22 18:20:56 -- Detecting CXX compiler ABI info
2024-06-22 18:20:57 -- Detecting CXX compiler ABI info - done
2024-06-22 18:20:57 -- Check for working CXX compiler: /usr/bin/clang++-17 - skipped
2024-06-22 18:20:57 -- Detecting CXX compile features
2024-06-22 18:20:57 -- Detecting CXX compile features - done
2024-06-22 18:20:57 -- Building infinity with CMake version: 3.29.0 On CLANG-17.0
2024-06-22 18:20:57 -- Build time = "2024-06-22 10:20.57"
2024-06-22 18:20:57 -- Found Git: /usr/bin/git (found version "2.34.1")
2024-06-22 18:20:57 -- Branch name = main
2024-06-22 18:20:57 -- Commit-id = 9465d1d
2024-06-22 18:20:57 -- Build type = Debug
2024-06-22 18:20:57 -- C++ Compilation flags: -O0 -g -fno-stack-protector -fno-var-tracking -Wall -Werror -Wno-asm-operand-widths -Wno-unused-command-line-argument -Wno-deprecated-declarations -Wno-read-modules-implicitly -Wextra -Wno-unused-parameter -Wno-unused-private-field -pthread -fcolor-diagnostics
2024-06-22 18:20:57 -- Found CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y
2024-06-22 18:20:57 CMake Warning (dev) at /usr/local/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
2024-06-22 18:20:57 The package name passed to find_package_handle_standard_args (LZ4) does
2024-06-22 18:20:57 not match the name of the calling package (Lz4). This can lead to problems
2024-06-22 18:20:57 in calling code that expects find_package result variables (e.g.,
2024-06-22 18:20:57 _FOUND) to follow a certain pattern.
2024-06-22 18:20:57 Call Stack (most recent call first):
2024-06-22 18:20:57 cmake/FindLz4.cmake:19 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
2024-06-22 18:20:57 CMakeLists.txt:144 (find_package)
2024-06-22 18:20:57 This warning is for project developers. Use -Wno-dev to suppress it.
2024-06-22 18:20:57
2024-06-22 18:20:57 -- Found LZ4: /usr/lib/x86_64-linux-gnu/liblz4.so
2024-06-22 18:20:57 -- Found LZ4: /usr/lib/x86_64-linux-gnu/liblz4.so
2024-06-22 18:20:59 -- Found Python: /usr/bin/python3.10 (found suitable version "3.10.12", minimum required is "3.8") found components: Interpreter Development.Module Development.SABIModule
2024-06-22 18:20:59 CMake Error at src/CMakeLists.txt:239 (message):
2024-06-22 18:20:59 This project requires the processor support fused multiply-add (FMA)
2024-06-22 18:20:59 instructions.
Env
local env: mac os M2
docker image : [ubuntu:22.04] amd64 (docker run -it --rm --platform linux/amd64 ubuntu:22.04)

Hello I follow Build from source on Ubuntu 22.04 , happen This project requires the processor support fused multiply-add (FMA) @yingfeng

@yingfeng
Copy link
Member

yingfeng commented Jun 22, 2024

You could try to remove instructions in CMake to see whether it could be compiled and run.

We do not have mac m1/m2, as a result we could not tell whether it could work correctly.

According to a PR from third party contributor, Infinity could be compiled under arm64(linux), while we have not made sure whether it could work normally. However, having infinity work under arm does belong to our roadmap for 0.3.

@xiaoshengMr
Copy link
Author

thanks,I tried it and it didn't work.

@xiaoshengMr
Copy link
Author

Thank you, Yinfeng. I rebuilt it on CentOS using Docker, and it was successful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants