Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More info needed when there's a NESTING_STEPS error #546

Closed
maktouch opened this issue Apr 18, 2024 · 2 comments
Closed

More info needed when there's a NESTING_STEPS error #546

maktouch opened this issue Apr 18, 2024 · 2 comments
Assignees
@jpwilliams
Labels
⬆️ improvement Performance, reliability, or usability improvements 📦 inngest Affects the `inngest` package

Comments

@maktouch
Copy link
Contributor

maktouch commented Apr 18, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
We've quickly migrated from graphile/worker to inngest. We now have over 160 functions. In my logs, I see "NESTING_STEPS" but there's no info to quickly debug that, as in, what function or step is causing this.

Describe the solution you'd like
I'd love to get the parent function, or the event, or even the step name, so I can go and fix this.

I can make a PR in this repo if you think it's valid!
@linear Linear
Copy link

linear bot commented Apr 18, 2024

INN-2958 More info needed when there's a NESTING_STEPS error

@jpwilliams jpwilliams mentioned this issue Apr 22, 2024
Merged
jpwilliams added a commit that referenced this issue Apr 23, 2024
@maktouch @jpwilliams
Add step name or ID when there’s a NESTING_STEPS error (#549)
f759de1 
## Summary
When there's a NESTING_STEPS error, debugging it is tricky because the
stack traces can't necessarily determine the correct faulty file.


## Checklist
~~- [ ] Added a [docs PR](https://github.com/inngest/website) that
references this PR~~ N/A, this is augmenting an existing error
~~- [ ] Added unit/integration tests~~ N/A, I don't think it's worth it
~~- [ ] Added changesets if applicable~~ N/A, I don't think it's worth
it.

## Related
- INN-2958
- #546

---------

Signed-off-by: Makara Sok <[email protected]>
Co-authored-by: Jack Williams <[email protected]>
@jpwilliams
Copy link
Member

This is shipped in 3.18.1 following #549.

Thanks, @maktouch!

I'm also noting #549 (comment), which highlights how rubbish the stack trace is for this instance: no usable lines and the prettyError header/footer have survived. This will be tracked in #531.

CleanShot 2024-04-22 at 12 47 33

@jpwilliams jpwilliams self-assigned this Apr 23, 2024
@jpwilliams jpwilliams added ⬆️ improvement Performance, reliability, or usability improvements 📦 inngest Affects the `inngest` package labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpwilliams jpwilliams

Labels
⬆️ improvement Performance, reliability, or usability improvements 📦 inngest Affects the `inngest` package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maktouch @jpwilliams