Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mithril client does not work in Windows Power Shell #2199

Closed
3 tasks done
jpraynaud opened this issue Jan 6, 2025 · 3 comments · Fixed by #2228
Closed
3 tasks done

Mithril client does not work in Windows Power Shell #2199

jpraynaud opened this issue Jan 6, 2025 · 3 comments · Fixed by #2228
Assignees
Labels
bug ⚠️ Something isn't working no-bug 🤓 Not a bug!

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Jan 6, 2025

Why

The Mithril client does not work in Power Shell (as explained in this discord thread: https://discord.com/channels/826816523368005654/1014019542504185876/1324413079731179520). This may be due to the printing of output not working properly.

What

Fix the client to work in Power Shell.

How

  • Investigate the problem
  • Fix the problem
  • Document the fix in the website
@jpraynaud jpraynaud added the bug ⚠️ Something isn't working label Jan 6, 2025
@jpraynaud jpraynaud changed the title Mithril client for windows does not work in Windows Power Shell Mithril client does not work in Windows Power Shell Jan 6, 2025
@Alenar
Copy link
Collaborator

Alenar commented Jan 10, 2025

I can't reproduce on a Windows 11 23H2.

It works on powershell 7:

C:\Users\User\Documents\Mithril\bin> $PSVersionTable.PSVersion

Major  Minor  Patch  PreReleaseLabel BuildLabel
-----  -----  -----  --------------- ----------
7      4      6

C:\Users\User\Documents\Mithril\bin> .\mithril-client --version
mithril-client 0.10.5+c6c7eba

On powershell 5 (the version bundled with windows):

PS C:\Users\User\Documents\Mithril\bin> $PSVersionTable.PSVersion

Major  Minor  Build  Revision
-----  -----  -----  --------
5      1      22621  4391


PS C:\Users\User\Documents\Mithril\bin> ./mithril-client --version
mithril-client 0.10.5+c6c7eba

It also work in the command prompt:

C:\Users\User\Documents\Mithril\bin>ver

Microsoft Windows [version 10.0.22631.4602]

C:\Users\User\Documents\Mithril\bin>mithril-client.exe --version
mithril-client 0.10.5+c6c7eba

And it work when building the code locally (here running in powershell 7):

C:\Dev\src\mithril [(2450.0)]> git status
HEAD detached at 2450.0
nothing to commit, working tree clean
C:\Dev\src\mithril [(2450.0)]> cargo run --bin mithril-client --release --features bundle_openssl -- --version
cargo 1.84.0 (66221abde 2024-11-19) running on `x86_64-pc-windows-msvc` target `x86_64-pc-windows-msvc`
    Finished `release` profile [optimized] target(s) in 0.49s
     Running `target\release\mithril-client.exe --version`
mithril-client 0.10.5

I'm currently upgrading my windows to 24H2 to see if the problem happen with this version (as it's know for being quite unstable).

@jpraynaud
Copy link
Member Author

I was able to reproduce the bug with these versions:

  • Microsoft Windows [version 10.0.26100.2605]
  • Power Shell 5.1.26100.2161

But now it works after restarting Windows 🤔

@Alenar
Copy link
Collaborator

Alenar commented Jan 10, 2025

Can't reproduce on Windows 11 24H2 either.

  • Windows version 10.0.26100.2605
  • Power Shell 5 version 5.1.26100.2161
  • Power Shell 7 version 7.4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ⚠️ Something isn't working no-bug 🤓 Not a bug!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants