-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document release process (and cut 0.4.1) #95
Comments
Sounds like a good plan! I have still to get around to doing any GHaction myself. The changelog could be generated from PR titles for now. |
Gentle nudge to see if we could we get a v0.4.1 tag for P.S. Happy to help out with repo maintainence if people have too much on their plate! |
right, thanks @weiji14 i've been a bit busy lately and would be happy if you released a new version! Note that it's probably worth sorting this issue out and adding a test for the many file case #94 (comment) |
Cool, I haven't got permissions on this repo but happy to get added to the team/organization here (and on PyPI?) to see what I can do for the release. The changelog actually said the release was on 2020-12-03, should we update that? The issue at #94 seems a bit complicated to write a test case for, and I'd suggest solving that in v0.4.2. |
Seems that I can't change repo permissions settings, @martindurant are you the only one currently with those permissions? |
yes for me |
Yep, I have the same username on PyPI. |
You are both added as maintainers on pypi |
Great, I'll push a v0.4.1 tag and the PyPI publish workflow at https://github.com/intake/intake-xarray/blob/31cb241f5cc74b01bd5d399b0d8fc695acf4063a/.github/workflows/pypipublish.yaml should work 🤞. |
Hmm, looking at https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#release, I think we need to change this line to use 'published' instead of 'created': intake-xarray/.github/workflows/pypipublish.yaml Lines 3 to 5 in 31cb241
|
Feel free to use twine locally too... I have never bothered to click the "release" button in github anyway |
Haven't used twine before 😂, I'll change the GitHub Actions workflow file and re-publish a new v0.4.1 release. Edit: done at 227c675 |
OK, whatever works for you! |
Ok, v0.4.1 is on PyPI at https://pypi.org/project/intake-xarray/0.4.1/ 😄 |
I'll merge the subsequent conda-forge PR when it comes through. |
Cool, happy to be added as a maintainer on https://github.com/conda-forge/intake-xarray-feedstock too 🙂 |
I think the easiest way is to make a PR adding you to the list of maintainers in the meta file |
It would be great to get a new release (0.4.1) out. @martindurant - I'd be happy to add a small section in the docs regarding your preferred way to do this.
Or we could add a "publish" github action to push to pypi as we're doing in intake-stac that just requires pushing a new tag. A changelog would also be nice to add.
The text was updated successfully, but these errors were encountered: