-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema jsonConfig.json - potentially missing definitions #24
Comments
cloned from ioBroker/adapter-react#29 (comment) In table items, most (all?) type specific definitions seams to be missing. noMultiEdit is missing completely. maxLength for type text is missing. The defaultFunc and onChange object syntax seams to be missing completely. This is used e.g. in linkeddevices here and here for example. |
What is not possible is to make table in table definitions. |
I still have the following schema mismatches / errors reported by vsCode: The following tabel attributes are reported as invalid: The following attributes of table elements ("items" array) are reported as invalid: I'm not sure what your last remark refering table in table definitions refers to. I only have one table inside a tab ("tabs" array). The complete json config raising errors at vsCode can be found here: |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions. |
This still an open issue |
|
New 'accordion' element is likely to be missing too |
For the initial |
As admin now validates the jsonConfig of every adapter against the schema, it is now crucial that the schema is up-to-date. Additional it will make sense to validate it in tests ioBroker/testing#583 |
@foxriver76 Which admin version includes the check so that I could test too. |
Schema always taken from https://github.com/ioBroker/adapter-react-v5/blob/main/schemas/jsonConfig.json Admin 6.12.0 includes the check whenever an adapter config is opened via browser. However, it will only log the first upcoming error, to not be too noisy. |
"cron" type is missing completely in the schema though it works and is documented at https://github.com/ioBroker/ioBroker.admin/blob/22bd130648ff2754922a91bcdbfad7e9fc278fc3/src/src/components/JsonConfigComponent/SCHEMA.md?plain=1#L263. |
cron has been added now, for the tables we have a separate issue at #183 |
Please create separate issues if more errors occur |
Moved from ioBroker/adapter-react#29 on request of GermanBluefox
I linked https://raw.githubusercontent.com/ioBroker/adapter-react-v5/master/schemas/jsonConfig.json to vsCode. vsCode reports the errors which seem to be caused by missing definitions in schema:
validatorNoSaveOnError
seems to be missing completly
validator, validatorErrorText, validatorNoSaveOnError
seems to be missing at table elements (item array of table). Validator is working, so the schema seems to be incorrect. As validatorErrorText does not seem to work the schema might be correct - in this case schema.md at admin is incorrect
default, hidden
seem to be missing at table elements (item array of table).
options
seems to be missing at table elements (item array of table) of type "select".
The text was updated successfully, but these errors were encountered: