Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainer error in parcel container: npm ERR! Missing script: "watch:parcel" #990

Closed
oweitman opened this issue Nov 19, 2022 · 6 comments

Comments

@oweitman
Copy link

the created parcel container stops because where is no watch:parcel script in package.json

npmScripts["prebuild"] = `rimraf admin/build`;

error message in the logs of parcel container

Installing all dependencies...
up to date, audited 478 packages in 4s
100 packages are looking for funding
  run `npm fund` for details
found 0 vulnerabilities
npm notice 
npm notice New major version of npm available! 8.19.2 -> 9.1.2
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.2>
npm notice Run `npm install -g [email protected]` to update!
npm notice 
npm ERR! Missing script: "watch:parcel"
�


the installed (test)-adapter configuration and other errors are described in thread
https://forum.iobroker.net/topic/36034/visualstudio-code-und-devcontainer/115

@mcm1957
Copy link
Contributor

mcm1957 commented Aug 8, 2023

@AlCalzone
Who can check / discuss this?

@oweitman
Is this issue still reproduceable with latest version of adapter creator?

@AlCalzone
Copy link
Collaborator

Is this issue still reproduceable

I think so, yes. There is exactly one occurence of watch:parcel and that's in the devcontainer script. Looks like that got forgotten when we switched the build process to esbuild: https://github.com/ioBroker/create-adapter/blob/master/docs/updates/20220215_esbuild.md

The devcontainer probably needs to be changed to use esbuild's serve mode instead of parcel: https://esbuild.github.io/api/#serve
Happy to take a PR if someone finds the time to figure this out and test it.

@oweitman I strongly recommend to use https://github.com/ioBroker/dev-server/ instead of the devcontainer instead.

@oweitman
Copy link
Author

oweitman commented Aug 8, 2023

it would not be that I would have tried the dev-server as well. but the situation is the same there. It is asked, but never answered to the end to reach a solution.
and this issue issnt opend by me, but i wrote the first time about this in forum
ioBroker/dev-server#286

by the way, why create a PR. these are not implemented either
#992

@AlCalzone
Copy link
Collaborator

AlCalzone commented Aug 8, 2023

Please retry with the latest version of the dev server. If that doesn't work, please provide a concrete example/repo/commit someone can use to reproduce your problem.

Are you saying the linked PR fixes your issue?
If so, how can we verify it works? A problematic adapter for example?

@oweitman
Copy link
Author

oweitman commented Aug 8, 2023

no the pr dosnt fix this issue.
as described it fix the not working websockets and addition removes a container that is useless, because there is no parcel anymore.
but i am repeating my self. please read the description of the pr

and you already wrote, that you missed yomething in changing from parcel to esbuild

@AlCalzone
Copy link
Collaborator

AlCalzone commented Aug 8, 2023

I'm repeating myself too: please provide a concrete example/repo/commit someone can use to reproduce your problem

Without that, this issue isn't likely to get fixed, as I (and likely the other devs too) am not going to spend my very limited time trying to read forum posts to figure out how to get to the same point you're stuck on.

Please make sure the issue description is complete and self-explanatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants