Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing translation for "Re-Announce" button #206

Closed
Feuer-sturm opened this issue Dec 6, 2024 · 9 comments
Closed

Missing translation for "Re-Announce" button #206

Feuer-sturm opened this issue Dec 6, 2024 · 9 comments
Assignees
@GermanBluefox
Labels
bug Something isn't working fixed issue is fixed and can be retested frontend/ui issue is relevant for matter adapter frontend/ui

Comments

@Feuer-sturm
Copy link
Collaborator

matter 0.2.6

Missing translation in german for "Re-Announce" button

grafik
@Feuer-sturm Feuer-sturm added bug Something isn't working frontend/ui issue is relevant for matter adapter frontend/ui labels Dec 6, 2024
@Feuer-sturm Feuer-sturm changed the title Missing translation for "Re-Announce" Missing translation for "Re-Announce" button Dec 6, 2024
@GermanBluefox
Copy link
Contributor

We cannot find the translation for "Re-announce", so works as designed

@GermanBluefox GermanBluefox added the fixed issue is fixed and can be retested label Dec 10, 2024
@Feuer-sturm
Copy link
Collaborator Author

@GermanBluefox @Apollon77 What is the functionaltiy behind "Re-Announce" in this case. The user gets the notification
grafik
but there is optical no change in the ui

@Feuer-sturm Feuer-sturm added the question Further information is requested label Dec 21, 2024
@Apollon77
Copy link
Collaborator

Apollon77 commented Dec 27, 2024 •
edited
Loading

In fact the announcement of a device to commission is active for max 15 minutes by default. after this it needs to be re-announced ... so basically "if you can not find it" ... If you have an better idea for the UI ... please tell

@Apollon77 Apollon77 removed the question Further information is requested label Dec 27, 2024
@Feuer-sturm
Copy link
Collaborator Author

If a timer of 15 minutes is running when the device is in pairing mode, then in my opinion this should also be displayed. For example, as a static text “Code is only valid for 15 minutes” or that a timer is expiring.

As a button text, I would prefer “Kopplungsmodus neu starten” or “Pairing neu starten” in German more descriptive than “Re-Announce”

@Feuer-sturm Feuer-sturm removed the fixed issue is fixed and can be retested label Dec 28, 2024
GermanBluefox added a commit that referenced this issue Dec 29, 2024
@GermanBluefox
Show message about 15 minutes for announcement: #206
2ce18ce
Apollon77 added a commit that referenced this issue Dec 31, 2024
@GermanBluefox @Apollon77
Updated packages (#270)
e53c181 
* Updated packages

* Show warning if more than 15 devices will be added to bridge at the beginning: #197

* Show message about 15 minutes for announcement: #206

---------

Co-authored-by: Ingo Fischer <[email protected]>
@Feuer-sturm Feuer-sturm added the fixed issue is fixed and can be retested label Dec 31, 2024
@Feuer-sturm
Copy link
Collaborator Author

matter 0.3.4

@Feuer-sturm Feuer-sturm added the question Further information is requested label Jan 1, 2025
@GermanBluefox
Copy link
Contributor

  • Der Text vom Button hat sich (noch) nicht geändert, sollte der Text über diese Änderung

Ja

@Feuer-sturm Feuer-sturm removed question Further information is requested fixed issue is fixed and can be retested labels Jan 6, 2025
@GermanBluefox GermanBluefox added the fixed issue is fixed and can be retested label Jan 6, 2025
@Feuer-sturm
Copy link
Collaborator Author

matter 0.3.5
@GermanBluefox
Text in Button is still "Re-Announce" and not as expected "Pairing neu starten"

@Feuer-sturm Feuer-sturm removed the fixed issue is fixed and can be retested label Jan 9, 2025
@GermanBluefox
Copy link
Contributor

Dann ist falsch gebaut.
image
https://github.com/ioBroker/ioBroker.matter/blob/main/src-admin/src/i18n/de.json#L129

GermanBluefox added a commit that referenced this issue Jan 10, 2025
@GermanBluefox
Translate Re-announce: #206
46c2cf4
@GermanBluefox GermanBluefox added the fixed issue is fixed and can be retested label Jan 10, 2025
Apollon77 pushed a commit that referenced this issue Jan 12, 2025
@GermanBluefox
Status action (#301)
be4396b 
* Made black button for info: #252

* Made black button for info: #252

* Formatting

* Changed translations

* Changed translations

* Changed translations

* Implementation of "click on status", "enable/disable"

* Implemented #289
Backend must be implemented

* Working on enabled/disabled

* Russian translation

* Changed links in welcome dialog: #237

* Fixing translation

* Fixing layout

* Added description for Controller fabric label: #297

* Improved login and password entering: #272

* Fixed compiler

* Changed description of 'Controller fabric label'

* Translate Re-announce: #206

* Changed saving of settings in welcome dialog

* Formatting

* Changed indication about changing item

* Changed translation

* Update packages

* Changed translations

* Implemented enable/disable
@Feuer-sturm
Copy link
Collaborator Author

fixed with matter 0.3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GermanBluefox GermanBluefox

Labels
bug Something isn't working fixed issue is fixed and can be retested frontend/ui issue is relevant for matter adapter frontend/ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GermanBluefox @Apollon77 @Feuer-sturm