Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECURITY: The /health endpoint should be on a different port than the webhook #73

Open
NickLarsenNZ opened this issue Jan 21, 2025 · 0 comments

Comments

@NickLarsenNZ
Copy link

NickLarsenNZ commented Jan 21, 2025

Problem

Currently, the /health endpoint runs on the same port as the webhook.

The webhook doesn't implement any authentication mechanism, which means you must expose the webhook to the rest of the cluster (and possibly outside the cluster, depending on the CNI) just to enable readiness/liveness probes.

It would be ideal to limit it to local connections from external-dns to external-dns-ionos-webhook when running as a side-car (ie: listen on 127.0.0.1). But this currently breaks the readiness/liveness probes.

Proposal:

Run a separate server (in a go routine) specifically for /health which can safely be exposed.

Similar to what is done (opt-in) for metrics: #70

@NickLarsenNZ NickLarsenNZ changed the title security: health endpoint should be on a different port than the webhook SECURITY: health endpoint should be on a different port than the webhook Jan 21, 2025
@NickLarsenNZ NickLarsenNZ changed the title SECURITY: health endpoint should be on a different port than the webhook SECURITY: The /health endpoint should be on a different port than the webhook Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant