Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Taints on ionoscloud_k8s_node_pool #225

Open
djjudas21 opened this issue Mar 10, 2022 · 4 comments
Open

Support Taints on ionoscloud_k8s_node_pool #225

djjudas21 opened this issue Mar 10, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@djjudas21
Copy link

Current Provider Version

[jgazeley@hephaestos cr-terraform]$ terraform version
Terraform v1.1.7
on linux_amd64
+ provider registry.terraform.io/hashicorp/kubernetes v2.8.0
+ provider registry.terraform.io/hashicorp/vault v3.3.1
+ provider registry.terraform.io/ionos-cloud/ionoscloud v6.1.6

Use-cases

I have created a ionoscloud_k8s_cluster with multiple ionoscloud_k8s_node_pool. I need to dedicate one node pool as an infrastructure node pool and this requires setting a taint on the node, as in the Openshift docs (also applicable to Kubernetes).

These Taints on the nodepools will then match Tolerations on the infrastructure pods (e.g. Ingress)

Attempted Solutions

I also considered setting Labels on the node pools but this then requires setting a NodeSelector on every workload pod, and is not a workable solution as it relies on every user of the cluster to remember to set a suitable NodeSelector.

resource "ionoscloud_k8s_node_pool" "infra" {
  ...
  labels = {
    "node-role.kubernetes.io/infra" = ""
  }
}

Proposal

The ionoscloud_k8s_node_pool resource should support setting taints on a node pool. For example, this syntax:

resource "ionoscloud_k8s_node_pool" "infra" {
  ...
  taints = {
    "node-role.kubernetes.io/infra" = "NoSchedule"
  }
}

would be used to represent this Taint on the underlying Kubernetes node pool object:

      taints: 
      - key: node-role.kubernetes.io/infra
        effect: NoSchedule
@djjudas21 djjudas21 added the enhancement New feature or request label Mar 10, 2022
@cristiGuranIonos
Copy link
Collaborator

cristiGuranIonos commented Mar 11, 2022

Thanks for raising this issue! We currently do not support this but it is on the roadmap. We will let you know once this is added.

@salyh
Copy link

salyh commented May 19, 2024

Any progress after more than 2 years?

@djjudas21
Copy link
Author

I worked around the problem by leaving IONOS and using different cloud platform 😉

@cristiGuranIonos
Copy link
Collaborator

We're sorry to hear that. We have asked for this feature, but due to a high number of products coming out, this feature did not get to production. It is scheduled to come out in the 4th quarter of the year. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants