From 81228105923da02b69bdbfe57a646369edbbad0d Mon Sep 17 00:00:00 2001
From: Hector Cruz <37127013+hect95@users.noreply.github.com>
Date: Wed, 4 Dec 2024 14:42:41 +0000
Subject: [PATCH] Fix rtcm logs (#8)

- Downgrade RTCM logs to debug level
  - Removed the warning log as it is unnecessary; GNSS RTK correction
continues to function correctly even when the NTRIP server does not
respond with an RTCM message.
- Ensure log file always operates at DEBUG level
  - Updated the logging configuration to guarantee that all logs are
captured at `DEBUG` level in the log file
- Preserve `DEBUG` log option for console output
---
 scripts/ntrip_client.py | 35 ++++++++++++++++++++---------------
 1 file changed, 20 insertions(+), 15 deletions(-)

diff --git a/scripts/ntrip_client.py b/scripts/ntrip_client.py
index 54d782d..3e6a1f8 100755
--- a/scripts/ntrip_client.py
+++ b/scripts/ntrip_client.py
@@ -101,15 +101,18 @@ def configure_logging(self):
         file_handler = logging.FileHandler(log_filename)
         file_handler.setFormatter(file_formatter)
 
-        # Determine the logging level based on debug_mode
-        if self.debug_mode:
-            logging.basicConfig(
-                level=logging.DEBUG, handlers=[console_handler, file_handler]
-            )
-        else:
-            logging.basicConfig(
-                level=logging.INFO, handlers=[console_handler, file_handler]
-            )
+        # Set specific log levels for each handler
+        console_handler.setLevel(
+            logging.DEBUG if self.debug_mode else logging.INFO
+        )
+        file_handler.setLevel(logging.DEBUG)
+
+        # Get the root logger and add the handlers
+        logger = logging.getLogger()
+        # Set root logger level to DEBUG to ensure all messages are processed
+        logger.setLevel(logging.DEBUG)
+        logger.addHandler(console_handler)
+        logger.addHandler(file_handler)
 
     def load_config(self, config_path):
         """
@@ -485,13 +488,15 @@ def read_rtcm_and_send_to_gnss(self):
                     # Keep track of RTCM message IDs
                     self.received_rtcm_msgs_ids[int(rtcm_msg.identity)] += 1
 
-                except exceptions.RTCMParseError as e:
-                    logging.warning(
-                        f'Error parsing RTCM data: {e}\n'
-                        f'Msg:\n {server_response}'
-                    )
+                except exceptions.RTCMParseError:
+                    # This catch is only to avoid runtime crashes
+                    pass
+
             else:
-                logging.warning(
+                # We don't mind if the NTRIP server response was not
+                # an RTCM message. The GNSS will know what to do
+                # with it. We just log it for future reference
+                logging.debug(
                     f'Non-RTCM msg received from Ntrip server:\n'
                     f'{server_response}'
                 )