.ipfs/api and --api does not parse SNI

[Jorropo]

If you try to use /dns4/example.com/tcp/443/https you would expect SNI and Host to be properly set but thoses are left blank.

This is because we are directly opening a tcp stream using manet.Dial. We should instead translate the multiaddress to an url and give the correct URL to net/http's client.
Example code that handle properly doing the conversion in libp2p: https://github.com/libp2p/go-libp2p/blob/305282b0cdda802712be5dbcf3b6921912613414/p2p/transport/websocket/addrs.go#L49

[MatthewCroughan]

More context:

It appears header appears that when using a dns or ip4 multiaddress with the --api flag kubo does not pass the Host: header along to the webserver on the other side. This means that if you're using a reverse proxy then you may not be proxied to the correct location, since the Host: header is used to determine how the network connection is routed.

An example CLI usage would be

ipfs --api /dns4/example.org/tcp/443/tls/http add ./file
ipfs --api /dns4/example.org/tcp/443/https add ./file

Kubo version: 0.21.0-dev
Repo version: 13
System version: amd64/linux
Golang version: go1.19.9

[MattSilvaa]

Hello! I'm willing to take this on if no one has started yet.

[Kiggins26]

@MattSilvaa have you done any work towards this, if not we can work on it together?

[MattSilvaa]

@Kiggins26 I have not started on this, feel free to take it.

[lidel]

This should be fixed by #10659 – ipfs id --api /dns/kubo-rpc.example.net/tcp/port/tls/http should hit https://kubo-rpc.example.net:port

Feel free to test latest master branch or docker image ipfs/kubo:master-2025-01-10-3b098b9, or wait for 0.33 (#10580) to be released