Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netmask is not applied properly #4

Open
rvbcldud opened this issue Aug 12, 2024 · 2 comments
Open

Netmask is not applied properly #4

rvbcldud opened this issue Aug 12, 2024 · 2 comments

Comments

@rvbcldud
Copy link
Contributor

There is an issue documented here that showcases a problem with how the netmask filters out the address range.

I think this has to do with how the network length is converted to a "character length." See here:

let network_len = net.prefix() as usize / 4;

In the aforementioned issue, a prefix length of 7 was given. The network_len would then be calculated as 1 "character," leaving 3 bits to be modified by the address rather than preserved by the netmask.

@rvbcldud
Copy link
Contributor Author

I will be working on a significant rework that uses a bit system instead of a character system. Stay tuned, @rushmorem.

@rvbcldud
Copy link
Contributor Author

Said rework has been completed in #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant