Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected connection and disconnection #1

Open
DanielOaks opened this issue Apr 14, 2019 · 2 comments
Open

Expected connection and disconnection #1

DanielOaks opened this issue Apr 14, 2019 · 2 comments

Comments

@DanielOaks
Copy link
Contributor

Scripts assume that clients:

  1. Connect at the start of the script.
  2. Never disconnect.

This is a bad assumption if we're going to be testing messages like QUIT, features like MONITOR and WATCH, and other sorts of things.

To do this, add a new client definition marker (!? or something, maybe?) that marks the given client will be connected in the future. Also mark a way to connect and disconnect clients. Maybe > to connect 'em, < to disconnect 'em, and <? to say 'process incoming messages until the client disconnects'.

@DanielOaks
Copy link
Contributor Author

Adding the <? marker first, that's a good one to have for testing a command like QUIT.

@DanielOaks
Copy link
Contributor Author

DanielOaks commented Apr 18, 2019

The <? marker is now added. I had to change the actual command line to accept name:< LINE HERE as well because for something like QUIT the PING we run afterwards to sync it fails, so it'd never get to the separate <? line. Example script added which goes through it all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant