Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: test created html #4

Closed
pared opened this issue Nov 17, 2021 · 1 comment
Closed

plots: test created html #4

pared opened this issue Nov 17, 2021 · 1 comment

Comments

@pared
Copy link
Contributor

pared commented Nov 17, 2021

We might not be aware what are our rendering limitations (#6894).
Even if we fix it (#6900) we need to manually test it in order to be sure the problem has been fixed.

It seems to me that we could limit such problems if we were able to somehow test our HTML.
In the cases mentioned above, if we were able to parse js code, execute it and get stderr output we could determine whether our visualization was successful.

Another thing to consider would be: how to check if the support for images works as intended?

This issue needs some research on that topic. Ideally, we would like to test produced HTML as any other tests.

Related: iterative/dvc#6944

@daavoo daavoo transferred this issue from iterative/dvc Feb 22, 2022
@daavoo
Copy link
Contributor

daavoo commented Sep 8, 2022

Closing in favor of #25

@daavoo daavoo closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants