Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BenchmarkResults fields should almost certainly use lenses #85

Open
rrnewton opened this issue Apr 26, 2015 · 1 comment
Open

BenchmarkResults fields should almost certainly use lenses #85

rrnewton opened this issue Apr 26, 2015 · 1 comment
Milestone

Comments

@rrnewton
Copy link
Member

As Issue #73 highlights, we really want to be able to refer to the "columns" (fields within the BenchmarkResult record) as first class entities.

This will be a pretty wide ranging change and will also introduce a substantial new dependency. Best to save for 2.0.

@rrnewton rrnewton added this to the 2.0 milestone Apr 26, 2015
@rrnewton rrnewton changed the title BenchmarkResults should almost certainly be a lens BenchmarkResults fields should almost certainly use lenses Apr 26, 2015
@rrnewton
Copy link
Member Author

There may still be an issue with (de)serializing the lenses.

At least in the DefaultParamMeaning context we need to be able to say WHICH field we're operating on, and that context (arbitrary Haskell code) it may be fine to just include the first class Lens' or Setter directly.

But there may be other contexts where we need to describe which field we're operating on as a String, so there will probably still be a boring dispatch function that needs to be maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant