Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSF 2.3 Challenge: Failing Resource Tests in TCK (Revisit) #1976

Open
volosied opened this issue Sep 17, 2024 · 2 comments
Open

JSF 2.3 Challenge: Failing Resource Tests in TCK (Revisit) #1976

volosied opened this issue Sep 17, 2024 · 2 comments
Labels
challenge TCK challenge

Comments

@volosied
Copy link
Contributor

Challenged Tests:

com.sun.ts.tests.jsf.api.javax_faces.application.resource.URLClient

  • resourceGetRequestPathLibTest
  • resourceGetRequestPathTest
  • resourceToStringTest

com.sun.ts.tests.jsf.api.javax_faces.application.resourcewrapper.URLClient

  • resourceWrapperGetRequestPathLibTest
  • resourceWrapperGetRequestPathTest

TCK Version:
JSF TCK 2.3.0

Tested Implementation:
Open Liberty with MyFaces 2.3.11-SNAPSHOT

Description:
The 4.0 TCK updated these tests as they were originally incorrect, as BalusC has pointed out in issue 1663. Links to the original issue and PR are posted below.

Can these tests be updated? It should be fairly simple to back port PR 1665.

References:
Issue: #1663

PR: #1665

Thank you

@volosied volosied added the challenge TCK challenge label Sep 17, 2024
@BalusC
Copy link
Member

BalusC commented Sep 22, 2024

We don't have TCK for JSF 2.3. We only have TCKs for Faces versions since Eclipse transfer. During the Oracle era, all TCKs were closed source.

cc: @arjantijms (how do we best salvage this? is that at all possible?)

@volosied
Copy link
Contributor Author

volosied commented Oct 3, 2024

Please let me know. If the tests can be excluding (without code changes), or some other option.

Worse case, we can revert the changes in MyFaces to get the TCK to pass again -- no one has seemed to complain about this behavior so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenge TCK challenge
Projects
None yet
Development

No branches or pull requests

2 participants