Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonical tags are incorrect #37

Open
excentrickristy opened this issue Nov 11, 2024 · 3 comments
Open

Canonical tags are incorrect #37

excentrickristy opened this issue Nov 11, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@excentrickristy
Copy link

excentrickristy commented Nov 11, 2024

During a recent crawl of the site I realized that the canonical URLs are being set incorrectly in the tutorial section of the website.

You can see here what the actual page url is vs the canoncial being set in the code:

image

This is the code in the template:
<link rel="canonical" href="https://jakarta.ee/learn/docs/jakartaee-tutorial/current/index.html/jakartaee-tutorial/current/index.html">

it looks like maybe a variable is being repeated here that shouldn't be. This is the case on all of the tutorial pages. If we can get this fixed it will help improve search indexing.

@excentrickristy
Copy link
Author

Bumping this. The site was hit hard in November during an algorithm rollout and I'm hoping we can get this issue fixed to improve search visibility.

@kito99 kito99 transferred this issue from jakartaee/jakartaee-tutorial Dec 19, 2024
@kito99 kito99 added bug Something isn't working help wanted Extra attention is needed labels Dec 19, 2024
@kito99
Copy link
Contributor

kito99 commented Dec 19, 2024

This appears to be related to the way Antora computes the canonical URL, and the url setting: https://docs.antora.org/antora/latest/playbook/set-up-playbook/.

@kito99 kito99 added the good first issue Good for newcomers label Dec 19, 2024
@excentrickristy
Copy link
Author

Just following up on this issue to see if we can get it corrected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants