Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test artifacts are using invalid versions of jakarta.tck dependencies #1805

Open
starksm64 opened this issue Jan 24, 2025 · 2 comments
Open

Comments

@starksm64
Copy link
Contributor

starksm64 commented Jan 24, 2025

Describe the bug
Some platform-tck test artifacts have dependencies on other jakarta.tck artifacts that are using a version that is not the currrent project.version value. For example, the jakarta.tck:rest-platform-tck has these out of date dependencies on the common, runtime and libutil artifacts:

    <dependency>
      <groupId>jakarta.tck</groupId>
      <artifactId>common</artifactId>
      <version>11.0.0-M2</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>jakarta.tck</groupId>
      <artifactId>runtime</artifactId>
      <version>11.0.0-M2</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>jakarta.tck</groupId>
      <artifactId>libutil</artifactId>
      <version>11.0.0-M2</version>
      <scope>compile</scope>
    </dependency>

Expected behavior
any jakarta.tck:* dependency should be using the current project.version of 11.0.0-SNAPSHOT to refer to the contents of the current build.

@arjantijms
Copy link
Contributor

I think the expected behavious is the reverse. They should not be using the current project.version, but they should be using the versions from maven cental.

The tools jars are just like that; tools. They are released to Maven Central, and as they are not the tests themselves do not need the EFTL license.

So i would recommend to close this issue, and keep using the tools jars as released to Maven Central. When needed, we can do a final release of these jars.

@starksm64
Copy link
Contributor Author

The tools jars are just one of many jakarta.tck groupId dependencies. When a release is cut, all artifacts under the platform-tck project should be versioned, staged, included in a dist bundle, tagged, and then released. Using different versions for different parts of the project is just error prone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants