Default input pin is not pulled high

[myhd]

The default pin PCINT3 in config.h is not pulled high, leading to floating states with a switch.

Even if this appears trivial, can you add an option to pull high the input pin? Currently, I am resorting to a 30k resistor.

(This repo is wonderful. Thank you for it. I happen to use it for the reason you created it in the first place.)

[jasonmhite]

Sure thing, I probably should have done that originally.

My AVR programming setup is in a box somewhere so I am not able to test, do you want to just do it and I can merge it in?

[myhd]

Thank your for your trust. I come from the Arduino universe, pure C is not my strength (yet). I have no idea how to do it. I can wait until you find your AVR setup.

[jasonmhite]

I think it's only a one line change, I'll double check and add it then maybe you can test it? Sounds like you have a 'tiny handy.

…

On Sun, Mar 28, 2021 at 2:52 PM Jakob Lehr ***@***.***> wrote: Thank your for your trust. I come from the Arduino universe, pure C is not my strength (yet). I have no idea how to do it. I can wait until you find your AVR setup. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGUC4ROEVBSXUFI7GQZV23TF6CJFANCNFSM4Z46WWWA> .

[myhd]

I think it's only a one line change, I'll double check and add it then maybe you can test it? Sounds like you have a 'tiny handy.

Yes I can, and yes I do!

[jasonmhite]

This is a note for myself, I'll add it in a branch and then you can try it out.

In main, should just need to add sbi(PORTB, INPUT_PIN); before the while while loop and wrap it in an ifdef. According to the datasheet, setting the appropriate bit in PORTB when the corresponding pin is set up in DDRB for input mode should activate the internal pullup.