Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Code #30

Open
jatiinyadav opened this issue Oct 3, 2021 · 7 comments
Open

Format Code #30

jatiinyadav opened this issue Oct 3, 2021 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest

Comments

@jatiinyadav
Copy link
Owner

  1. Add/Create a js folder and move javascript files in js folder.
  2. Inline styling in .js files should be in style.scss.
  3. Make sure that your are making styling changes in style.scss file not in style.css file.
@jatiinyadav jatiinyadav added enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest labels Oct 3, 2021
@keivalya
Copy link

keivalya commented Oct 3, 2021

Please assign this to me. I would like to try.

@jatiinyadav
Copy link
Owner Author

@keivalya Are you working on this?

@keivalya
Copy link

keivalya commented Oct 9, 2021

Hey @jatiinyadav !
Can you elaborate a little bit on how to accomplish 2 and 3. I am not sure what it actually means.

@jatiinyadav
Copy link
Owner Author

Screenshot 2021-10-09 114132
You have to remove inline css from javascript files and create class/id in style.scss file.

Use Live Sass Compiler if you're using Visual Studio Code (VSCode) and enable the live sass compiling. Live Sass Compiler

  1. Do styling changes in style.scss file.
  2. Click on Watch Sass at the bottom of your VSCode.

Screenshot 2021-10-08 184620

  1. Your Sass Folder will look like this:-

Screenshot 2021-10-08 184648

  1. If you are facing any difficulties you can refer to this documentation.

@keivalya
Copy link

keivalya commented Oct 9, 2021

Thank you so much, I will get it done as soon as possible.

@jatiinyadav
Copy link
Owner Author

@keivalya Are you working on this?

@keivalya keivalya removed their assignment Oct 15, 2021
@keivalya
Copy link

I am sorry, I have exams from tomorrow and hence, won't be able to work on this issue any longer.
Sincere apologies for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants