Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests? #9

Open
GitMensch opened this issue Oct 26, 2017 · 3 comments
Open

Unit Tests? #9

GitMensch opened this issue Oct 26, 2017 · 3 comments

Comments

@GitMensch
Copy link
Collaborator

It looks like the program was started from the standard maven artifact. It therefore includes junit and (before the conversion to GitHub) had an empty test folder.

Do you have any unit tests to add (otherwise I'll drop the junit dependency [a small overhaul of the POM is the last thing I plan to do])?

@ipolevoy
Copy link
Member

this is a simple GUI app, not sure what can be tested, but you are free to add if you like

@GitMensch
Copy link
Collaborator Author

The GUI parts are not nice to test with junit, testing the underlying EntryIndex / ClassInformation and obviously javad parts would be the task at hand.

I just wanted to add the folders (silencing maven), but then tested the old/new javad versions (which still can be used from jar-explorer.jar) as integration test (mainly checking for uncatched Exceptions).
This already brought 30% test coverage (without the important part of checking the actual output [as it has to be verified at least once manually] ). I've added a test class for raising it to 37%, but the real thing to do is to add some specific unit tests with verifying its output.

@ipolevoy actually there are some things that likely should run with the current tests, but aren't:
accData coverage, but these may get in when tests for org.jarexplorer are added.

Maybe you find the time to generate some simple test cases for EntryIndex / ClassInformation.
I'm leaving this as is-now, having added at least some testing (mostly for "not raises an exception") with 1f43cab.

@ipolevoy
Copy link
Member

ipolevoy commented Nov 1, 2017

I do not recall writing this, maybe this class is some proof of concept? I'm stressed by current project, if you feel adding tests will benefit, go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants