Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc chores #22

Merged
merged 33 commits into from
Sep 10, 2024
Merged

Misc chores #22

merged 33 commits into from
Sep 10, 2024

Conversation

javalsai
Copy link
Owner

@javalsai javalsai commented Sep 3, 2024 •
edited
Loading

  • Add support for more init systems
    • runit
    • openrc
    • s6
  • Write man pages
    • Generic man page
    • Talk about config
    • Talk about service files
    • Change AUR pkgbuilds
    • Change flake
  • Fix all build warnings.
    • -Wunused-result missing, can't seem to appear on my system 😔
    • Other warnings
  • Add documentation on install methods
    • AUR
    • flake
    • ...
  • Work on themes
    • Too many ppl complain abt "swell" and "wuser"... on the default theme
    • Too much "tasteless" and "old blue" themes instead of actual ones that people might want
    • Make new theme screenshots
  • Audit config file, currently it's a mess.
    • Audit the rest too (this will be fixed probably with a better config parser, likely toml based)
    • I think all keys have to be specified and keys like colors.f_other are unused.
    • There's also inconsistencies as colors.s_wl before colors.s_xorg, but then having strings.s_xorg before strings.s_wayland (different name and order)
  • Grammar
    • codespell shows a few things...
    • project description is literally "a ✨fully✨ colorful customizable TUI"
  • CI
    • Simplify build process
    • Consider adding codespell
    • Consider adding a C linter/formatter
    • Support more architectures by default
      • aarch64
      • armv7
      • riscv

@javalsai javalsai self-assigned this Sep 3, 2024
javalsai and others added 18 commits September 4, 2024 16:12
@javalsai
feat: add manpages and improve service docs
9de4551
@grialion
fix: Makefile paths on Nix
b4fbe68 
Makefile installed the binary as /bin instead of copying it to the

folder which was not present.

Also use PREFIX for man pages too.
@javalsai
feat: add openrc support
ae4e4df
@javalsai
oops: add openrc install detection
2fb0e0e
@javalsai
feat: add s6 suport
6d3c3cb
@javalsai
fix: sysd service file (moved to tty7)
f9a3c67
@javalsai
chore: proper default theme strings 😔
aba3b49
@grialion
fix: compiler warnings
64e101e 
Fix compiler warnings by
- replacing raw write() calls with printf()
- error checking chdir()
- printing '\x1b[H\x1b[J' instead of calling system(clear)
- using sys/reboot.h to power off and reboot instead of using system
@javalsai
fix: ui bugs introduced in last commit
1a8aa1a
@javalsai
chore: remove unnecessary pam header uses
462d1fd 
those actually cause issues when trying to cross-compile
@javalsai
fix: grammar (codespell)
730e6db
@javalsai
feat: add LIDM_CONF config path override
7ca864f
@javalsai
docs: add separate install guide
b18ed23
@javalsai
format: markdown files
72858a9
@javalsai
format: add clang-format config
b34528d
@javalsai
format: let clang-format run ._.
dbbab78 
(won't even talk about clang-tidy)
@javalsai
chore: remove config inconsistencies
2284ab0
@javalsai
themes: add kanagawa themes and organize themes
286cd01 
removed old-blue-thick and pure-tastelessness

renamed tastelessness to nothing
@javalsai
Copy link
Owner Author

javalsai commented Sep 5, 2024

I should also make AUR pkgs use make install DESTDIR="${pkgdir}" or smth

@javalsai
feat: update pkgbuilds
e746d63 
hmm, manpages and not much more
untested changes, needs a release
@javalsai javalsai marked this pull request as ready for review September 6, 2024 20:40
@javalsai
Copy link
Owner Author

javalsai commented Sep 6, 2024

Finally, done, only gotta test the PKGBUILDS (I need a release for that), but given that only remaining changes are related to AUR pkgs, not anything of code or CI, this can be merged.

I also have to make multiarch pkgs, but that comes after the stuff I mentioned above.

@javalsai
Copy link
Owner Author

javalsai commented Sep 6, 2024

And after that I can fix clang-tidy errors to add it, or even automatically update pkgbuilds on a release with the appropriate hashes on the release.yml workflow.

@javalsai
Copy link
Owner Author

javalsai commented Sep 6, 2024 •
edited
Loading

Also, just noticed some markdown indexes (at least README.md's) are outdated

@javalsai
Copy link
Owner Author

javalsai commented Sep 7, 2024

@grialion this done now frfr, approve whenever u want plss

@javalsai javalsai added the enhancement New feature or request label Sep 7, 2024
Pickzelle
Pickzelle approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@Pickzelle Pickzelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@javalsai javalsai merged commit 8071694 into master Sep 10, 2024
13 checks passed
@javalsai javalsai deleted the misc-chores branch September 10, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pickzelle Pickzelle Pickzelle approved these changes

Assignees

@javalsai javalsai

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javalsai @Pickzelle @grialion