Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for seeding model #26

Open
rfriedman22 opened this issue Nov 15, 2022 · 1 comment
Open

Add support for seeding model #26

rfriedman22 opened this issue Nov 15, 2022 · 1 comment

Comments

@rfriedman22
Copy link

Currently there is no support for seeding random number generators, which would be useful for reproducibility purposes. A user can seed the RNG on their own using the following three lines:

random.seed(seed)
np.random.seed(seed)
tf.random.set_seed(seed)

However, it might be helpful to build this into model.fit by providing the seed as an optional argument to the method.

@atareen
Copy link
Collaborator

atareen commented Nov 17, 2022

Hi Ryan,

Thanks for writing. We tried implementing what you suggested in Mave-nn prior to the release of version 1.0.1, nearly exactly as you have suggested. With the version of Tensorflow we were using at the time (close to 2.0.0) we found that models still didn't behave identically, even after specifying all these seeds.

Mave-nn is undergoing active development, to be released as Mave-nn2 some time in the near future, and I can re-try to fix the seed so that Mave-nn2 gives identical models.

Thanks,
Ammar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants