-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using spacial distances masks some escape sites #161
Comments
@Bernadetadad, just looking at this qualitatively, I don't think it is a bug per set but perhaps just limitations of spatial regularization. First off, the chain thing is not a bug. If you look at the inter_residue_distances function you see it is returning the closest pair of sites across all chains, which are usually the ones in the same monomer. But the The regularization operates on the mean escape at a site, not the total. So if you click on the mean plots, you see for the non-regularized ones the mean escape is a lot higher for 420 and 487 than for 371, as at 371 only a single mutation escapes. Whether the normalization should actually be on the total is a sort of subjective question. But I think the main issue here is that site 371 is not spatially proximal to sites 420 and 487 in the RBD if you look at the structure. This is because the 371 mutation probably affects up-down conformation of the RBD and is mostly acting that way. So the spatial regularization argues against them being in the same epitope as it doesn't know about things like RBD up-down. It may be that the solution is to just drop the regularization weights. Right now If decreasing it helps, maybe see if you think that also helps for other fitting. If so, let me know and we could potentially change the default. Anyway, can you report back on this issue what you find? |
Setting |
OK, maybe try on sera etc and see if you think it is better to just set default weight to zero or make it smaller, and if this should be overall |
Just a follow up, including spacial regularization for antibodies with the pipeline default values ( |
I will update defaults on this some after we also decide about antibody count defaults. |
@fwelsh, do you have a thought on good spatial regularization defaults for your data? |
@jbloom I don't use spatial regularization if I'm only fitting one epitope. For multiple epitopes, I could get reasonable deconvolution if I set reg_spatial2_weight to around 0.001 or 0.01, which is quite high. I don't really understand the logic behind using spatial regularization for single-epitope models? Penalizing the model for trying to put distant sites in the same epitope makes sense. But when we're just fitting one epitope, this seems like it would add unreasonable constraints and artificially skew the data towards a more targeted immune profile. I could just be misunderstanding the role of spatial regularization here, though, let me know what you think! |
I ran
COV-3600
antibody with the latest polyclonal version with and withoutspatial_distances
and it gives very different results, namely, addition of spatial distance parameter significantly changes key escape sites seen before (such as site 420 and 486). It is not clear to me why that is the case. Attached is zipped html comparing escape with or without added spatial distances.COV-3600
barcode runs are in BA.2 repo.One thing I noticed is that spacial distances table does not include information for distances between or within all chains. E.g., in the attached image I read in A, B and C chains but the spacial distances table only includes information for distances between sites 371-420 for chains A and C. This is the case regardless of which
.pdb
I use, is it supposed to work like this as the distances within and between chains should be different?COV3600.html.zip
The text was updated successfully, but these errors were encountered: