Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create RPM Package #66

Open
turicas opened this issue Sep 29, 2015 · 7 comments
Open

Create RPM Package #66

turicas opened this issue Sep 29, 2015 · 7 comments

Comments

@turicas
Copy link

turicas commented Sep 29, 2015

This work is already being made by some Fedora contributors and (I expect) will be available soon in the official repositories.
You may want to watch the process: https://bugzilla.redhat.com/show_bug.cgi?id=1266273

Note: I'm watching becase a library I develop depends on unicodecsv and I want to have it packaged to Fedora.

@apevec
Copy link

apevec commented Sep 30, 2015

Thanks for watching, python-unicodecsv-0.14.1-1.fc24 is now available in Fedora Rawhide.
BTW I would like to drop python3-* which doesn't seem to be necessary and I had to patch python-cliff 1.15 to pass py3 tests, see https://review.openstack.org/226966

@turicas
Copy link
Author

turicas commented Sep 30, 2015

I think the Python 3 package is not necessary (I'm not contrary to removing it) but it could be very useful since we (as unicodecsv users) don't need to check Python version and use unicodecsv or csv (we can just use unicodecsv).

@jdunck, what do you think?

@apevec
Copy link

apevec commented Sep 30, 2015

See #65 where it was mentioned:

You're using unicodecsv as a drop-in replacement for csv. The problem is that it's only a reasonable drop-in replacement for Python 2 csv. If it attempted to be a drop-in replacement for Python 3's as well, it would be a different API

@turicas
Copy link
Author

turicas commented Sep 30, 2015

@apevec, you're right. :)

@ryanhiebert
Copy link
Collaborator

Yeah, at least with 0.14.1, that's certainly the case. I have #67 open that compromises the mental model a bit so that it can be a drop-in replacement. I'd love feedback on whether that magical approach is really a good idea or not.

@apevec
Copy link

apevec commented Oct 5, 2015

AFAICT conclusion in #67 is to keep advertising py3 compatibility but document clearly that it is not a drop-in replacement for py3 csv module.
As such, Fedora RPM will keep python3-unicodecsv subpackage with modified summary:
-Summary: Drop-in replacement for csv module which supports unicode strings
+Summary: Python 2/3 csv shim, not a replacement for py3 csv module

Better wording suggestions welcome!

@ryanhiebert
Copy link
Collaborator

-Summary: Drop-in replacement for csv module which supports unicode strings
+Summary: Drop-in replacement for Python 2.7's csv module which supports unicode strings

It's the same distinction as the README gives.

If there's a longer description that a one-line summary, a note that it's not a replacement for Python 3's csv module is appropriate. But you can't put everything in a single summary line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants