Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: when changing path, should file adjust accordingly (?) #13

Open
LukasGentele opened this issue May 25, 2020 · 2 comments
Open

Comments

@LukasGentele
Copy link
Contributor

LukasGentele commented May 25, 2020

Currently, if you want to build a Dockerfile in a subdirectory, you'll have to adjust path and file. However, when changing the context using docker build some/other/context, Docker would also prefer the file some/other/context/Dockerfile according to the context (if not specified otherwise).

Should this action also follow this style and use the Dockerfile within path if not otherwise specified? Would be a breaking change but I think it would be more consistent with the Docker CLI experience.

@jerray Happy to submit a PR if you think this idea makes sense.

@jerray
Copy link
Owner

jerray commented May 26, 2020

Good idea! I didn't think too much about relation between path and file when I create this action.

Looking forward to see your PR. Thank you!

@patsevanton
Copy link

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants