Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Migrate off run_after_success #679

Open
simonswine opened this issue Jan 11, 2019 · 3 comments
Open

Migrate off run_after_success #679

simonswine opened this issue Jan 11, 2019 · 3 comments
Assignees
Labels
area/test-infra kind/technical-debt priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@simonswine
Copy link
Contributor

simonswine commented Jan 11, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened:

Prow is removing support for run_after_success kubernetes/test-infra#10694 (comment)

What you expected to happen:

We should keep support in our fork for longer until an alternative build pipeline model is available through knative.

/cc @munnerz

@munnerz
Copy link
Contributor

munnerz commented Feb 21, 2019

👋 has there been any thought as to when this might happen? I'd like to be able to bump Prow 😄

Would it be possible to get this scheduled into a milestone? I think just running all tests for all PRs initially would probably be okay, given the (relatively) low volume of jobs.

@munnerz
Copy link
Contributor

munnerz commented Feb 21, 2019

(I'm happy to make the changes to move your jobs away from run_after_success and just running on all pushes, if that's a direction you're happy with - I'd just rather not block Prow bumps on this for an extended period)

@munnerz
Copy link
Contributor

munnerz commented Feb 21, 2019

After discussing with @simonswine, I think a rough plan:

  • At the start of the 0.7 cycle, we'll move all run_after_success jobs to run unconditionally (i.e. just absorb the cost of running more jobs)
  • We can then bump Prow, and ensure all is working as expected without causing interruption
  • We then have the chance to investigate and explore the knative-pipeline support that is still in the works, in our own time

Assigning to myself as I'll pick up the work to move tarmak off run_after_success after 0.6's release.

If anyone doesn't feel like this plan works well, please comment 😄

/assign
/milestone v0.7

@munnerz munnerz added area/test-infra kind/technical-debt priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/test-infra kind/technical-debt priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

2 participants