Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database-migration modules can't be applied without jpa-persistence #11677

Closed
murdos opened this issue Jan 3, 2025 · 7 comments · Fixed by #11796
Closed

database-migration modules can't be applied without jpa-persistence #11677

murdos opened this issue Jan 3, 2025 · 7 comments · Fixed by #11796
Assignees
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: database migration theme: database $500 https://www.jhipster.tech/bug-bounties/

Comments

@murdos
Copy link
Contributor

murdos commented Jan 3, 2025

It should be possible to use liquibase (or flyway) with jooq, in which case you don't want to apply a jpa-* module.

image

A possible solution would be to introduce a new "datasource" or "sql-database" feature, with "postgresql", "mysql", "mariadb" and "sqlserver" modules.
jpa-* and jooq-* modules would depend on these new sql-database modules.

image

This would also avoid current code duplication between jpa and jooq.

@murdos
Copy link
Contributor Author

murdos commented Jan 25, 2025

@pascalgrimaud @renanfranca @fabienpuissant If you don't have any objection to this proposal, I'm going to work on it.

@fabienpuissant
Copy link
Collaborator

Is it the refacto we mentionned to mutualise persistency ? Instead of duplicating all for jpa and jooq

@murdos
Copy link
Contributor Author

murdos commented Jan 25, 2025

Yes. And it will allow using liquibase with jooq.

@renanfranca
Copy link
Contributor

It's fine for me :) ✌️

@pascalgrimaud
Copy link
Member

Fine for me too, @murdos

@murdos murdos self-assigned this Jan 25, 2025
@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ labels Jan 26, 2025
pascalgrimaud pushed a commit that referenced this issue Jan 26, 2025
@murdos
Copy link
Contributor Author

murdos commented Jan 26, 2025

@pascalgrimaud
Copy link
Member

@murdos : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: database migration theme: database $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants