Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frames for Music Videos in List/LowList views #121

Open
jingai opened this issue Sep 19, 2016 · 1 comment
Open

Frames for Music Videos in List/LowList views #121

jingai opened this issue Sep 19, 2016 · 1 comment
Milestone

Comments

@jingai
Copy link
Owner

jingai commented Sep 19, 2016

Note that we have to deal with two different aspect ratios here: might be an album cover or a screenshot from the video (which can be 4:3 or 16:9 among other ratios).

Don't add frames if we're currently in an addon, because we can't tell what the icon is!

@jingai jingai added this to the 3.4.0 milestone Sep 19, 2016
@jingai
Copy link
Owner Author

jingai commented Sep 20, 2016

This is not currently doable (as of Kodi 17) because we can't tell whether ListItem.Icon contains a square icon or fanart (usually a screenshot from the video). ListItem.Art(fanart) isn't implemented in Music Videos so they do it differently.

@jingai jingai removed this from the 3.4.0 milestone Sep 20, 2016
@jingai jingai added this to the 4.1.0 milestone May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant