Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulate_bundle rpc method does not return full result on transaction error #678

Open
OSadovy opened this issue Sep 16, 2024 · 3 comments
Open

Comments

@OSadovy
Copy link

OSadovy commented Sep 16, 2024

Problem

When calling the simulate_bundle RPC method and one of transactions fails due to e.g. custom thrown error from an instruction, the result does not contain neither logs nor consumed compute units, and the error itself is returned only as string which makes it cumbersome to parse.

example result:

Response { context: RpcResponseContext { slot: 290184069, api_version: Some(RpcApiVersion(Version { major: 2, minor: 0, patch: 5 })) }, value: RpcSimulateBundleResult { summary: Failed { error: TransactionFailure(<REDACTED>, "Error processing Instruction 3: custom program error: 0x1772"), tx_signature: Some("<REDACTED>") }, transaction_results: [] } }

As you can see, only summary field is returned; the transaction_results is empty.

Proposed Solution

transaction_results should be returned; It has all the fields that standard solana simulate_transaction rpc method returns: logs, consumed compute units etc. This helps to debug failures.

@0xdeepmehta
Copy link

@segfaultdoc, pretty please, we really need it!

@jordan-patapoff
Copy link

+1 would be super helpful to have this

@cheliosooo
Copy link

+1 on this as well, really need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants