Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom package: Black lines in minimap #17

Open
jmanuel1 opened this issue Jan 18, 2023 · 0 comments
Open

Atom package: Black lines in minimap #17

jmanuel1 opened this issue Jan 18, 2023 · 0 comments

Comments

@jmanuel1
Copy link
Owner

I think the minimap package does not understand that we're doing syntax highlighting. In fact, the Grammar subclass doesn't return any tokens in tokenizeLine which I think explains why the lines in the minimap are black. Atom's grammar tokens are supposed to collectively cover the whole text, but our grammar tokens cover none of the text because there are no tokens.
image

Possible solutions:

  • Have a textmate grammar. Use the Concat lexer to overlay extra information on top of it.
  • Give Atom the currently known tokens when it asks for them from the grammar. We get the tokens asynchronously, so maybe what we display will be out of date.
  • Plug into the minimap package.

I'm not of fan of the second option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant