-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toucan Results #5
Comments
Thanks @darbyjohnston! I updated the toucan render steps in the README. Do you mind if I add/adapt your Python script into the test suite? I'd like to include an "Almost Right" detection for results that are within some +/- tolerance. |
Thanks for updating the README and feel free to include/modify the script. Adding a tolerance sounds like a great idea. |
I updated the results and the Python script; there was a bug in the original script not handling newlines, and I made the output more granular so it's not just pass/fail. The new output shows a percentage for each test and the maximum difference between frames. I think the difference is helpful so you can see how far off the frame values are. Just a note about the Toucan results, most of the low scores are from the "trim to fill" and "reverse" tests which are issues with the source .otio file (#2, #1). |
I saw the nice results that @camkerr added for Resolve and NukeStudio, so I thought I would also add some for toucan:
Instead of using diff to compare the overall results, I wrote a small Python script that compares each clip. I don't write a lot of Python, hopefully the logic is correct:
Also toucan now supports writing movie files directly, so the example command line in the README can be simplified a bit:
The text was updated successfully, but these errors were encountered: