Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--start-date argument not getting respected #318

Closed
NiklasKK opened this issue Jan 15, 2024 · 5 comments
Closed

--start-date argument not getting respected #318

NiklasKK opened this issue Jan 15, 2024 · 5 comments
Assignees
Labels
bug Something isn't working triage This will looked at

Comments

@NiklasKK
Copy link

NiklasKK commented Jan 15, 2024

Describe the bug

The --start-date argument was not working as intended. I provided 2024-04-19 as start date, but received a Pushover notification for a night from the 17th to the 18th.

Original Camply Command

camply campsites --campground 232447 --campground 232449 --start-date 2024-04-19 --end-date 2024-04-21 --notifications pushover --search-forever

Expected behavior

I expected to not get a notification for any nights before the 19th.

Console Output (with --debug)

No console output as I am running it in the background.

Additional context

This is a screenshot of the Pushover notification I received:

IMG_FEB384CDA875-1

@NiklasKK NiklasKK added the bug Something isn't working label Jan 15, 2024
@github-actions github-actions bot added the triage This will looked at label Jan 15, 2024
@juftin
Copy link
Owner

juftin commented Jan 15, 2024

Is this behavior consistent or intermittent?

@NiklasKK
Copy link
Author

I'm pretty sure I saw it happen multiple times but sadly I deleted the Pushover notifications, but will definitely take another screenshot if I see it happening again.

@juftin
Copy link
Owner

juftin commented Jan 16, 2024

FWIW I ran through the following commands and each time the days returned increases by one as expected while respecting the lower bound:

camply campsites --campground 232447 --campground 232449 --start-date 2024-04-20 --end-date 2024-04-21
camply campsites --campground 232447 --campground 232449 --start-date 2024-04-19 --end-date 2024-04-21
camply campsites --campground 232447 --campground 232449 --start-date 2024-04-18 --end-date 2024-04-21
camply campsites --campground 232447 --campground 232449 --start-date 2024-04-17 --end-date 2024-04-21

Is it possible you had multiple camply searches with different windows running at the same time? I'm spitballing here but keep me posted on if you see the issue occur again

@NiklasKK
Copy link
Author

Yeah, you were right.
I actually had a copy paste error for my other search where I unintentionally pasted the 232447 campground.
So everything working correctly, sorry for the trouble 😄

@juftin
Copy link
Owner

juftin commented Jan 17, 2024

Thanks for the follow up here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage This will looked at
Projects
None yet
Development

No branches or pull requests

2 participants