Fix Timeline Slider Visibility in Status Bar for Certain Documents

[Meriem-BenIsmail]

This PR resolves an issue where the timeline slider in the status bar was not appearing for certain documents. The problem stemmed from overly restrictive checks in the isActive method of the statusBarTimeline plugin.

[github-actions]

👈 Launch a Binder on branch Meriem-BenIsmail/jupyter-collaboration/bug-timeline

[davidbrochart]

So it seems that this PR just doesn't check that the shared model has a document_id anymore. Could you explain why this check was here in the first place, and in which case a shared model may not have a document_id?

[Meriem-BenIsmail]

So it seems that this PR just doesn't check that the shared model has a document_id anymore. Could you explain why this check was here in the first place, and in which case a shared model may not have a document_id?

The document_id check was originally added to ensure the timeline slider interacted with uniquely identifiable collaborative documents.
However, this check caused issues for non-notebook documents because their shared models typically don’t define a document_id (in the example of text files, markdown files..., we can't find the document_id)

By removing the check, the timeline slider now works more broadly with all collaborative documents, not just those with a document_id.

[davidbrochart]

Thanks @Meriem-BenIsmail. I was also curious about this check: typeof currentWidget.context.path === 'string'.

[Meriem-BenIsmail]

I was also curious about this check: typeof currentWidget.context.path === 'string'

Oh that was first added when I was going to check for the RTC prefix in the path later. I'll remove it