Skip to content
This repository has been archived by the owner on Jan 7, 2023. It is now read-only.

Finish S3 Blobstore implementation #18

Open
iorubs opened this issue Jun 4, 2020 · 0 comments
Open

Finish S3 Blobstore implementation #18

iorubs opened this issue Jun 4, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@iorubs
Copy link
Member

iorubs commented Jun 4, 2020

Description
The code is almost identical to the existing File BlobStore implementation (in fact it has already been added to nexus/blobstore_s3.go)

The problem is that testing that code is a bit awkward, because it requires valid creds connecting connecting to S3.

We already have a mocking test suite in place and a bunch of api mock examples (look up test with MockedClientSuite). So we just need to come up with the mocking data and test code.

Acceptance:

  • Enable s3 api methods
  • Using the nexus api (http://localhost:8081/#admin/system/api) manually perform all the different tasks and store the results. (note this requires valid AWS creds).
  • Create tests using mock data based on the sults from the previous step.
@iorubs iorubs added the enhancement New feature or request label Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant