Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with hue mode #26

Closed
vulinhpc opened this issue Mar 10, 2019 · 2 comments
Closed

Bug with hue mode #26

vulinhpc opened this issue Mar 10, 2019 · 2 comments
Labels
need verification Possible bug that needs to be verified

Comments

@vulinhpc
Copy link

When I use color picker alpha script in customizer together with twentynineteen theme, it causing js bug.
I found that the theme has hue color option:

$wp_customize->add_control(
	new WP_Customize_Color_Control(
		$wp_customize,
		'primary_color_hue',
		array(
			'description' => __( 'Apply a custom color for buttons, links, featured images, etc.', 'twentynineteen' ),
			'section'     => 'colors',
			'mode'        => 'hue',
		)
	)
);

http://prntscr.com/mvqlq4
and It seem bug when mode is hue(it works without 'mode' =>'hue')
// Create a color picker which only allows adjustments to the hue.
if ( self.options.type === 'hue' ) {
return self._createHueOnly();

		}

the bug come when return self._createHueOnly();

Please check,
Thank you!

@kallookoo kallookoo transferred this issue from kallookoo/wp-color-picker-alpha-plugin Mar 10, 2019
@kallookoo kallookoo added the need verification Possible bug that needs to be verified label Mar 10, 2019
@kallookoo
Copy link
Owner

Hi @vulinhpc
It should work, it will not be because of what you mention #25

@kallookoo
Copy link
Owner

Closed, now it checks if it is valid and does nothing if it is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need verification Possible bug that needs to be verified
Projects
None yet
Development

No branches or pull requests

2 participants