Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F890: highlighting #65

Open
babslgam opened this issue Oct 4, 2024 · 4 comments
Open

F890: highlighting #65

babslgam opened this issue Oct 4, 2024 · 4 comments
Assignees

Comments

@babslgam
Copy link
Contributor

babslgam commented Oct 4, 2024

@BOberreither please check, if the F890 passages are already highlighted correctly.

@BOberreither
Copy link

BOberreither commented Oct 8, 2024

Looks very good so far, thanks!

Some more details (sorry):

  • Here there seem to be two layers of color on the lg element:
    doubleColor
    I can see the same issue with the long quote in paragraph 64 ( "Karl Kraus' Bedeutung ...") and the following one ("Kraus gehört zu einem teilweise ...") - maybe it's because of the long quote?

  • Please compare this F890-highlighting of an lg to the lg-highlight on this page. The one in paragraph 18 covers the whole line, the one in paragraph 2 only the width of the lines. Is there a way to highlight the whole line in all cases?

  • In Register.xml there are citeRange-Elements referred to by the @corresp in the F890-segs. Unless that's already your plan, just a little reminder to show this bibliographical info (like with intertexts) in the right column after Click on short info ("Die Fackel von Ende Juli 1934, S. 1–315").

  • Klick on an app/rdg element also activates/deactivates the info for the whole seg in right column. This should not be triggered by clicking on app/rdg.

@BOberreither BOberreither assigned babslgam and unassigned BOberreither Oct 8, 2024
@babslgam
Copy link
Contributor Author

babslgam commented Nov 8, 2024

@BOberreither issues should be resolved, but please check again.

@BOberreither
Copy link

Looks great, thanks @babslgam !
Small things:

  • par. 21 shows a seg without the highlighting of the app; the app mechanism in info column still works, but then there is no way to click the whole seg to get the bibliographical info. (Would this change if the nesting of seg and quote would be the other way around?)
  • par. 25 I found an app that's not displayed correctly: "Auch der Boden ...", in the end. Maybe because of the prev/next-mechanism?
  • Same paragraph, the one below, again a prev/next issue?
  • Same here, par. 40 ("weh dir ...")
  • Same in par 41, at the end
  • Same in par 49
  • Same paragraph, passage "mit einem Juden" - is in , but spacing in rdg DW is not shown in info column.
  • Par. 57, "Mit der einzigen Ausnahme der physischen Gewalt gegen die Gegner" should be highlighted as well
  • This and the next highlight have a margin on the left, unlike the ones to follow ...

@BOberreither BOberreither removed their assignment Dec 2, 2024
@babslgam
Copy link
Contributor Author

babslgam commented Dec 4, 2024

@BOberreither:
i adapted the <app>-highlighting. will send you a link with the test report showing the changes.
regarding "wrong" margin: the nesting is different: once longQuoteVerse is inside the app and once its outside.
regarding missing spacing: the <hi> is outside the app, but infocolumn content is based on app elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants