Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when using with cocoapods #3

Open
ecoopnet opened this issue Nov 19, 2015 · 0 comments
Open

Crash when using with cocoapods #3

ecoopnet opened this issue Nov 19, 2015 · 0 comments

Comments

@ecoopnet
Copy link

SRGVersionUpdater.executeVersionCheck() always occurs assertion error of BlocksKit when there is updates.

AppDelegate.swift:

      let versionUpdater = SRGVersionUpdater()
      versionUpdater.endPointUrl = url
      versionUpdater.executeVersionCheck()

And the assertion error was raised here

- (NSInteger)bk_addButtonWithTitle:(NSString *)title handler:(void (^)(void))block
    NSAssert(title.length, @"A button without a title cannot be added to the alert view.");

because self.updateButtonText was null at this code:

    [alert bk_addButtonWithTitle:[self updateButtonText]
                         handler:^(void) {
        NSURL *updateUrl = [NSURL URLWithString:versionInfo[@"update_url"]];
        [[UIApplication sharedApplication] openURL:updateUrl];
    }];

I think it is same as this issue:
MatthewYork/DateTools#56

My environment:
Xcode: 7.1 (Swift)
CocoaPods version 0.39.0

Podfile:

# coding: utf-8
source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '8.0'
use_frameworks!

pod 'SRGVersionUpdater'

I could fix it by copying SRGVersionUpdater.Bundle directory into main Xcode project.
But it is good to be fixed inside of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant