Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kedro-datasets: missing metadata parameter #699

Closed
michal-mmm opened this issue May 27, 2024 · 2 comments
Closed

kedro-datasets: missing metadata parameter #699

michal-mmm opened this issue May 27, 2024 · 2 comments

Comments

@michal-mmm
Copy link
Contributor

Description

Currently, not all datasets have a metadata parameter.

Context

Some kedro plugins use this parameter to extend basic functionality (e.g. kedro-viz, kedro-pandera).

Steps to Reproduce

Examples:
https://github.com/kedro-org/kedro-plugins/blob/main/kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py#L217 - ManagedTableDataset
https://github.com/kedro-org/kedro-plugins/blob/main/kedro-datasets/kedro_datasets/polars/eager_polars_dataset.py#L61 - EagerPolarsDataset

Expected Result

All datasets should have a metadata parameter.
@michal-mmm michal-mmm mentioned this issue May 30, 2024
Merged
4 tasks
@astrojuanlu
Copy link
Member

Fixed in #708

@astrojuanlu
Copy link
Member

Thank you @michal-mmm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astrojuanlu @michal-mmm